qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
	Greg Kurz <groug@kaod.org>, David Hildenbrand <david@redhat.com>
Subject: [PULL 05/11] softmmu/physmem.c: Fix typo in comment
Date: Sat, 23 Oct 2021 20:31:17 +0200	[thread overview]
Message-ID: <20211023183123.813116-6-laurent@vivier.eu> (raw)
In-Reply-To: <20211023183123.813116-1-laurent@vivier.eu>

From: Greg Kurz <groug@kaod.org>

Fix the comment to match what the code is doing, as explained in
the changelog of commit 86cf9e154632cb28d749db0ea47946fba8cf3f09
that introduced the change:

    Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization
    of vCPU and migration operations through calling run_on_cpu operation.
    However, in replay mode this synchronization is unneeded, because
    I/O and vCPU threads are already synchronized.
    This patch disables such synchronization for record/replay mode.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <163429018454.1146856.3429437540871060739.stgit@bahia.huguette>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
 softmmu/physmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index f67ad2998121..555c907f6743 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -2633,7 +2633,7 @@ static void tcg_log_global_after_sync(MemoryListener *listener)
          * In record/replay mode this causes a deadlock, because
          * run_on_cpu waits for rr mutex. Therefore no races are possible
          * in this case and no need for making run_on_cpu when
-         * record/replay is not enabled.
+         * record/replay is enabled.
         cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener);
         run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL);

  parent reply	other threads:[~2021-10-23 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 18:31 [PULL 00/11] Trivial branch for 6.2 patches Laurent Vivier
2021-10-23 18:31 ` [PULL 01/11] po: update turkish translation Laurent Vivier
2021-10-23 18:31 ` [PULL 02/11] disas/nios2: Fix style in print_insn_nios2() Laurent Vivier
2021-10-23 18:31 ` [PULL 03/11] disas/nios2: Simplify endianess conversion Laurent Vivier
2021-10-23 18:31 ` [PULL 04/11] MAINTAINERS: Add myself as reviewer of 'Machine core' API Laurent Vivier
2021-10-23 18:31 ` Laurent Vivier [this message]
2021-10-23 18:31 ` [PULL 06/11] hw/nvram: Fix Memory Leak in Xilinx eFuse QOM Laurent Vivier
2021-10-23 18:31 ` [PULL 07/11] hw/nvram: Fix Memory Leak in Xilinx Versal eFuse device Laurent Vivier
2021-10-23 18:31 ` [PULL 08/11] hw/nvram: Fix Memory Leak in Xilinx ZynqMP " Laurent Vivier
2021-10-23 18:31 ` [PULL 09/11] README: Fix some documentation URLs Laurent Vivier
2021-10-23 18:31 ` [PULL 10/11] analyze-migration.py: fix a long standing typo Laurent Vivier
2021-10-23 18:31 ` [PULL 11/11] analyze-migration.py: fix extract contents ('-x') errors Laurent Vivier
2021-10-23 23:22 ` [PULL 00/11] Trivial branch for 6.2 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211023183123.813116-6-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=david@redhat.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --subject='Re: [PULL 05/11] softmmu/physmem.c: Fix typo in comment' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).