netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] wcn36xx: add missing 5GHz channels 136 and 144
@ 2021-10-22 23:57 Benjamin Li
  2021-10-22 23:57 ` [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit Benjamin Li
  2021-10-22 23:57 ` [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
  0 siblings, 2 replies; 6+ messages in thread
From: Benjamin Li @ 2021-10-22 23:57 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Bryan O'Donoghue, Loic Poulain, linux-arm-msm, Benjamin Li,
	David S. Miller, Jakub Kicinski, wcn36xx, linux-wireless, netdev,
	linux-kernel

Think Bryan's commit was accidentally lost during upstreaming of his original
WCN3680 support patches, so I've included it here.

Omitted Fixes: tag as this was a regression from downstream prima, but not a
regression from previous versions of wcn36xx.

Benjamin Li (1):
  wcn36xx: add missing 5GHz channels 136 and 144

Bryan O'Donoghue (1):
  wcn36xx: Switch on Antenna diversity feature bit

 drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
 drivers/net/wireless/ath/wcn36xx/smd.c  | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit
  2021-10-22 23:57 [PATCH 0/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
@ 2021-10-22 23:57 ` Benjamin Li
  2021-10-25  8:23   ` Kalle Valo
  2021-10-22 23:57 ` [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
  1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Li @ 2021-10-22 23:57 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Bryan O'Donoghue, Loic Poulain, linux-arm-msm, Benjamin Li,
	David S. Miller, Jakub Kicinski, wcn36xx, linux-wireless, netdev,
	linux-kernel

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Switches on Antenna diversity feature bit.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Benjamin Li <benl@squareup.com>
---
 drivers/net/wireless/ath/wcn36xx/smd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 3979171c92dd..be6442b3c80b 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -2394,8 +2394,10 @@ int wcn36xx_smd_feature_caps_exchange(struct wcn36xx *wcn)
 	INIT_HAL_MSG(msg_body, WCN36XX_HAL_FEATURE_CAPS_EXCHANGE_REQ);
 
 	set_feat_caps(msg_body.feat_caps, STA_POWERSAVE);
-	if (wcn->rf_id == RF_IRIS_WCN3680)
+	if (wcn->rf_id == RF_IRIS_WCN3680) {
 		set_feat_caps(msg_body.feat_caps, DOT11AC);
+		set_feat_caps(msg_body.feat_caps, ANTENNA_DIVERSITY_SELECTION);
+	}
 
 	PREPARE_HAL_BUF(wcn->hal_buf, msg_body);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144
  2021-10-22 23:57 [PATCH 0/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
  2021-10-22 23:57 ` [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit Benjamin Li
@ 2021-10-22 23:57 ` Benjamin Li
  2021-10-23  9:55   ` Bryan O'Donoghue
  2021-10-25  8:35   ` Kalle Valo
  1 sibling, 2 replies; 6+ messages in thread
From: Benjamin Li @ 2021-10-22 23:57 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Bryan O'Donoghue, Loic Poulain, linux-arm-msm, Benjamin Li,
	David S. Miller, Jakub Kicinski, wcn36xx, linux-wireless, netdev,
	linux-kernel

These channels missing from scan results are a regression from downstream
prima.

Signed-off-by: Benjamin Li <benl@squareup.com>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
 drivers/net/wireless/ath/wcn36xx/smd.c  | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 263af65a889a..13d09c66ae92 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -85,7 +85,9 @@ static struct ieee80211_channel wcn_5ghz_channels[] = {
 	CHAN5G(5620, 124, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
 	CHAN5G(5640, 128, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_HIGH),
 	CHAN5G(5660, 132, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_LOW),
+	CHAN5G(5680, 136, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_LOW),
 	CHAN5G(5700, 140, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
+	CHAN5G(5720, 144, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_HIGH),
 	CHAN5G(5745, 149, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_LOW),
 	CHAN5G(5765, 153, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_LOW),
 	CHAN5G(5785, 157, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index be6442b3c80b..9785327593d2 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -2396,6 +2396,7 @@ int wcn36xx_smd_feature_caps_exchange(struct wcn36xx *wcn)
 	set_feat_caps(msg_body.feat_caps, STA_POWERSAVE);
 	if (wcn->rf_id == RF_IRIS_WCN3680) {
 		set_feat_caps(msg_body.feat_caps, DOT11AC);
+		set_feat_caps(msg_body.feat_caps, WLAN_CH144);
 		set_feat_caps(msg_body.feat_caps, ANTENNA_DIVERSITY_SELECTION);
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144
  2021-10-22 23:57 ` [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
@ 2021-10-23  9:55   ` Bryan O'Donoghue
  2021-10-25  8:35   ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2021-10-23  9:55 UTC (permalink / raw)
  To: Benjamin Li, Kalle Valo
  Cc: Loic Poulain, linux-arm-msm, David S. Miller, Jakub Kicinski,
	wcn36xx, linux-wireless, netdev, linux-kernel

On 23/10/2021 00:57, Benjamin Li wrote:
> These channels missing from scan results are a regression from downstream
> prima.
> 
> Signed-off-by: Benjamin Li <benl@squareup.com>
> ---
>   drivers/net/wireless/ath/wcn36xx/main.c | 2 ++
>   drivers/net/wireless/ath/wcn36xx/smd.c  | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index 263af65a889a..13d09c66ae92 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -85,7 +85,9 @@ static struct ieee80211_channel wcn_5ghz_channels[] = {
>   	CHAN5G(5620, 124, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
>   	CHAN5G(5640, 128, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_HIGH),
>   	CHAN5G(5660, 132, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_LOW),
> +	CHAN5G(5680, 136, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_LOW),
>   	CHAN5G(5700, 140, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
> +	CHAN5G(5720, 144, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_HIGH),
>   	CHAN5G(5745, 149, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_LOW),
>   	CHAN5G(5765, 153, PHY_QUADRUPLE_CHANNEL_20MHZ_HIGH_40MHZ_LOW),
>   	CHAN5G(5785, 157, PHY_QUADRUPLE_CHANNEL_20MHZ_LOW_40MHZ_HIGH),
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index be6442b3c80b..9785327593d2 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -2396,6 +2396,7 @@ int wcn36xx_smd_feature_caps_exchange(struct wcn36xx *wcn)
>   	set_feat_caps(msg_body.feat_caps, STA_POWERSAVE);
>   	if (wcn->rf_id == RF_IRIS_WCN3680) {
>   		set_feat_caps(msg_body.feat_caps, DOT11AC);
> +		set_feat_caps(msg_body.feat_caps, WLAN_CH144);
>   		set_feat_caps(msg_body.feat_caps, ANTENNA_DIVERSITY_SELECTION);
>   	}
>   
> 

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit
  2021-10-22 23:57 ` [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit Benjamin Li
@ 2021-10-25  8:23   ` Kalle Valo
  0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2021-10-25  8:23 UTC (permalink / raw)
  To: Benjamin Li
  Cc: Bryan O'Donoghue, Loic Poulain, linux-arm-msm,
	David S. Miller, Jakub Kicinski, wcn36xx, linux-wireless, netdev,
	linux-kernel

Benjamin Li <benl@squareup.com> writes:

> From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> Switches on Antenna diversity feature bit.

The commit log should answer to the question "why?":

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144
  2021-10-22 23:57 ` [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
  2021-10-23  9:55   ` Bryan O'Donoghue
@ 2021-10-25  8:35   ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2021-10-25  8:35 UTC (permalink / raw)
  To: Benjamin Li
  Cc: Bryan O'Donoghue, Loic Poulain, linux-arm-msm,
	David S. Miller, Jakub Kicinski, wcn36xx, linux-wireless, netdev,
	linux-kernel

Benjamin Li <benl@squareup.com> writes:

> These channels missing from scan results are a regression from downstream
> prima.

Please write commit logs in a way that everybody can understand, I doubt
very few know what "are a regression from downstream prima" means.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-25  8:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 23:57 [PATCH 0/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
2021-10-22 23:57 ` [PATCH 1/2] wcn36xx: Switch on Antenna diversity feature bit Benjamin Li
2021-10-25  8:23   ` Kalle Valo
2021-10-22 23:57 ` [PATCH 2/2] wcn36xx: add missing 5GHz channels 136 and 144 Benjamin Li
2021-10-23  9:55   ` Bryan O'Donoghue
2021-10-25  8:35   ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).