netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Quentin Monnet <quentin@isovalent.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 0/5] bpftool: Switch to libbpf's hashmap for referencing BPF objects
Date: Mon, 25 Oct 2021 17:32:49 -0700	[thread overview]
Message-ID: <CAEf4BzZWaA1yunTjfcvwZ_UU2vLrVnqwzJMFCj9qEbGDsLmBPA@mail.gmail.com> (raw)
In-Reply-To: <20211023205154.6710-1-quentin@isovalent.com>

On Sat, Oct 23, 2021 at 1:52 PM Quentin Monnet <quentin@isovalent.com> wrote:
>
> When listing BPF objects, bpftool can print a number of properties about
> items holding references to these objects. For example, it can show pinned
> paths for BPF programs, maps, and links; or programs and maps using a given
> BTF object; or the names and PIDs of processes referencing BPF objects. To
> collect this information, bpftool uses hash maps (to be clear: the data
> structures, inside bpftool - we are not talking of BPF maps). It uses the
> implementation available from the kernel, and picks it up from
> tools/include/linux/hashtable.h.
>
> This patchset converts bpftool's hash maps to a distinct implementation
> instead, the one coming with libbpf. The main motivation for this change is
> that it should ease the path towards a potential out-of-tree mirror for
> bpftool, like the one libbpf already has. Although it's not perfect to
> depend on libbpf's internal components, bpftool is intimately tied with the
> library anyway, and this looks better than depending too much on (non-UAPI)
> kernel headers.
>
> The first two patches contain preparatory work on the Makefile and on the
> initialisation of the hash maps for collecting pinned paths for objects.
> Then the transition is split into several steps, one for each kind of
> properties for which the collection is backed by hash maps.
>
> v2:
>   - Move hashmap cleanup for pinned paths for links from do_detach() to
>     do_show().
>   - Handle errors on hashmap__append() (in three of the patches).
>   - Rename bpftool_hash_fn() and bpftool_equal_fn() as hash_fn_for_key_id()
>     and equal_fn_for_key_id(), respectively.
>   - Add curly braces for hashmap__for_each_key_entry() { } in
>     show_btf_plain() and show_btf_json(), where the flow was difficult to
>     read.
>
> Quentin Monnet (5):
>   bpftool: Remove Makefile dep. on $(LIBBPF) for $(LIBBPF_INTERNAL_HDRS)
>   bpftool: Do not expose and init hash maps for pinned path in main.c
>   bpftool: Switch to libbpf's hashmap for pinned paths of BPF objects
>   bpftool: Switch to libbpf's hashmap for programs/maps in BTF listing
>   bpftool: Switch to libbpf's hashmap for PIDs/names references
>
>  tools/bpf/bpftool/Makefile |  12 ++--
>  tools/bpf/bpftool/btf.c    | 132 +++++++++++++++++--------------------
>  tools/bpf/bpftool/common.c |  50 ++++++++------
>  tools/bpf/bpftool/link.c   |  45 ++++++++-----
>  tools/bpf/bpftool/main.c   |  17 +----
>  tools/bpf/bpftool/main.h   |  54 +++++++--------
>  tools/bpf/bpftool/map.c    |  45 ++++++++-----
>  tools/bpf/bpftool/pids.c   |  90 ++++++++++++++-----------
>  tools/bpf/bpftool/prog.c   |  45 ++++++++-----
>  9 files changed, 262 insertions(+), 228 deletions(-)
>
> --
> 2.30.2
>

Applied to bpf-next, thanks.

      parent reply	other threads:[~2021-10-26  0:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 20:51 Quentin Monnet
2021-10-23 20:51 ` [PATCH bpf-next v2 1/5] bpftool: Remove Makefile dep. on $(LIBBPF) for $(LIBBPF_INTERNAL_HDRS) Quentin Monnet
2021-10-23 20:51 ` [PATCH bpf-next v2 2/5] bpftool: Do not expose and init hash maps for pinned path in main.c Quentin Monnet
2021-10-23 20:51 ` [PATCH bpf-next v2 3/5] bpftool: Switch to libbpf's hashmap for pinned paths of BPF objects Quentin Monnet
2021-10-23 20:51 ` [PATCH bpf-next v2 4/5] bpftool: Switch to libbpf's hashmap for programs/maps in BTF listing Quentin Monnet
2021-10-23 20:51 ` [PATCH bpf-next v2 5/5] bpftool: Switch to libbpf's hashmap for PIDs/names references Quentin Monnet
2021-10-26  0:32 ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzZWaA1yunTjfcvwZ_UU2vLrVnqwzJMFCj9qEbGDsLmBPA@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    --cc=quentin@isovalent.com \
    --subject='Re: [PATCH bpf-next v2 0/5] bpftool: Switch to libbpf'\''s hashmap for referencing BPF objects' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).