linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Remove unused semaphores
@ 2021-10-22  8:47 Fabio M. De Francesco
  2021-10-22  8:47 ` [PATCH 1/2] staging: r8188eu: Remove initialized but unused semaphore Fabio M. De Francesco
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Fabio M. De Francesco @ 2021-10-22  8:47 UTC (permalink / raw)
  To: Larry Finger, Phillip Potter, Greg Kroah-Hartman, linux-staging,
	linux-kernel
  Cc: Fabio M. De Francesco

Remove two unused semaphores.

Fabio M. De Francesco (2):
  staging: r8188eu: Remove initialized but unused semaphore
  staging: r8188eu: Remove unused semaphore "io_retevt"

 drivers/staging/r8188eu/core/rtw_xmit.c      | 1 -
 drivers/staging/r8188eu/include/osdep_intf.h | 1 -
 drivers/staging/r8188eu/include/rtw_xmit.h   | 1 -
 3 files changed, 3 deletions(-)

-- 
2.33.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] staging: r8188eu: Remove initialized but unused semaphore
  2021-10-22  8:47 [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
@ 2021-10-22  8:47 ` Fabio M. De Francesco
  2021-10-22  8:47 ` [PATCH 2/2] staging: r8188eu: Remove unused semaphore "io_retevt" Fabio M. De Francesco
  2021-10-22  8:54 ` [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio M. De Francesco @ 2021-10-22  8:47 UTC (permalink / raw)
  To: Larry Finger, Phillip Potter, Greg Kroah-Hartman, linux-staging,
	linux-kernel
  Cc: Fabio M. De Francesco

Remove semaphore "xmit_sema" from "struct adapter" because it is
initialized but never used.

Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_xmit.c    | 1 -
 drivers/staging/r8188eu/include/rtw_xmit.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index 720e190a7436..0c033a077bf9 100644
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -49,7 +49,6 @@ s32	_rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
 	/*  We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
 
 	spin_lock_init(&pxmitpriv->lock);
-	sema_init(&pxmitpriv->xmit_sema, 0);
 	sema_init(&pxmitpriv->terminate_xmitthread_sema, 0);
 
 	/*
diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h
index ea8e82e0b4be..b2df1480d66b 100644
--- a/drivers/staging/r8188eu/include/rtw_xmit.h
+++ b/drivers/staging/r8188eu/include/rtw_xmit.h
@@ -256,7 +256,6 @@ struct agg_pkt_info {
 
 struct	xmit_priv {
 	spinlock_t lock;
-	struct semaphore xmit_sema;
 	struct semaphore terminate_xmitthread_sema;
 	struct __queue be_pending;
 	struct __queue bk_pending;
-- 
2.33.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] staging: r8188eu: Remove unused semaphore "io_retevt"
  2021-10-22  8:47 [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
  2021-10-22  8:47 ` [PATCH 1/2] staging: r8188eu: Remove initialized but unused semaphore Fabio M. De Francesco
@ 2021-10-22  8:47 ` Fabio M. De Francesco
  2021-10-22  8:54 ` [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
  2 siblings, 0 replies; 5+ messages in thread
From: Fabio M. De Francesco @ 2021-10-22  8:47 UTC (permalink / raw)
  To: Larry Finger, Phillip Potter, Greg Kroah-Hartman, linux-staging,
	linux-kernel
  Cc: Fabio M. De Francesco

Remove semaphore "io_retevt" because it is never used.

Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
 drivers/staging/r8188eu/include/osdep_intf.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/r8188eu/include/osdep_intf.h b/drivers/staging/r8188eu/include/osdep_intf.h
index 90b37655e9e0..0d7009269aab 100644
--- a/drivers/staging/r8188eu/include/osdep_intf.h
+++ b/drivers/staging/r8188eu/include/osdep_intf.h
@@ -34,7 +34,6 @@ The protection mechanism is through the pending queue.
 	struct urb *piorw_urb;
 	u8 io_irp_cnt;
 	u8 bio_irp_pending;
-	struct semaphore  io_retevt;
 	struct timer_list io_timer;
 	u8 bio_irp_timeout;
 	u8 bio_timer_cancel;
-- 
2.33.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Remove unused semaphores
  2021-10-22  8:47 [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
  2021-10-22  8:47 ` [PATCH 1/2] staging: r8188eu: Remove initialized but unused semaphore Fabio M. De Francesco
  2021-10-22  8:47 ` [PATCH 2/2] staging: r8188eu: Remove unused semaphore "io_retevt" Fabio M. De Francesco
@ 2021-10-22  8:54 ` Fabio M. De Francesco
  2021-10-22  9:01   ` Greg Kroah-Hartman
  2 siblings, 1 reply; 5+ messages in thread
From: Fabio M. De Francesco @ 2021-10-22  8:54 UTC (permalink / raw)
  To: Larry Finger, Phillip Potter, Greg Kroah-Hartman, linux-staging,
	linux-kernel

On Friday, October 22, 2021 10:47:25 AM CEST Fabio M. De Francesco wrote:
> Remove two unused semaphores.
> 
> Fabio M. De Francesco (2):
>   staging: r8188eu: Remove initialized but unused semaphore
>   staging: r8188eu: Remove unused semaphore "io_retevt"
> 
>  drivers/staging/r8188eu/core/rtw_xmit.c      | 1 -
>  drivers/staging/r8188eu/include/osdep_intf.h | 1 -
>  drivers/staging/r8188eu/include/rtw_xmit.h   | 1 -
>  3 files changed, 3 deletions(-)
> 
> -- 
> 2.33.1

I'm sorry but I overlooked the name of the driver in this cover letter :(
Am I required to send a v2?

Fabio




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] Remove unused semaphores
  2021-10-22  8:54 ` [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
@ 2021-10-22  9:01   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-10-22  9:01 UTC (permalink / raw)
  To: Fabio M. De Francesco
  Cc: Larry Finger, Phillip Potter, linux-staging, linux-kernel

On Fri, Oct 22, 2021 at 10:54:26AM +0200, Fabio M. De Francesco wrote:
> On Friday, October 22, 2021 10:47:25 AM CEST Fabio M. De Francesco wrote:
> > Remove two unused semaphores.
> > 
> > Fabio M. De Francesco (2):
> >   staging: r8188eu: Remove initialized but unused semaphore
> >   staging: r8188eu: Remove unused semaphore "io_retevt"
> > 
> >  drivers/staging/r8188eu/core/rtw_xmit.c      | 1 -
> >  drivers/staging/r8188eu/include/osdep_intf.h | 1 -
> >  drivers/staging/r8188eu/include/rtw_xmit.h   | 1 -
> >  3 files changed, 3 deletions(-)
> > 
> > -- 
> > 2.33.1
> 
> I'm sorry but I overlooked the name of the driver in this cover letter :(
> Am I required to send a v2?

Please do.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-22  9:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22  8:47 [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
2021-10-22  8:47 ` [PATCH 1/2] staging: r8188eu: Remove initialized but unused semaphore Fabio M. De Francesco
2021-10-22  8:47 ` [PATCH 2/2] staging: r8188eu: Remove unused semaphore "io_retevt" Fabio M. De Francesco
2021-10-22  8:54 ` [PATCH 0/2] Remove unused semaphores Fabio M. De Francesco
2021-10-22  9:01   ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).