linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] staging: vt6655: fix camelcase byData in card.c
@ 2021-10-18 19:21 Tommaso Merciai
  2021-10-19  5:49 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Tommaso Merciai @ 2021-10-18 19:21 UTC (permalink / raw)
  Cc: tomm.merciai, Forest Bond, Greg Kroah-Hartman,
	Marcos Antonio de Jesus Filho, Dan Carpenter, Lucas Henneman,
	linux-staging, linux-kernel

Replace camelcase variable "byData" into linux kernel coding style
equivalent variable "data" in card.c.
"by" prefix in hungarian notation stands for byte or unsigned char

References:
 - https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
 - https://www.kernel.org/doc/html/v4.10/process/coding-style.html

Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
---
Changes since v1:
 - Make the commit body message more clearer

 drivers/staging/vt6655/card.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 26e08fec6e6a..fac2d0566d2e 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -183,7 +183,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
 	unsigned char bySlot = 0;
 	unsigned char bySIFS = 0;
 	unsigned char byDIFS = 0;
-	unsigned char byData;
+	unsigned char data;
 	int i;
 
 	/* Set SIFS, DIFS, EIFS, SlotTime, CwMin */
@@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
 			priv->abyBBVGA[0] = 0x20;
 			priv->abyBBVGA[2] = 0x10;
 			priv->abyBBVGA[3] = 0x10;
-			bb_read_embedded(priv, 0xE7, &byData);
-			if (byData == 0x1C)
+			bb_read_embedded(priv, 0xE7, &data);
+			if (data == 0x1C)
 				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
 
 		} else if (priv->byRFType == RF_UW2452) {
 			MACvSetBBType(priv->port_offset, BB_TYPE_11A);
 			priv->abyBBVGA[0] = 0x18;
-			bb_read_embedded(priv, 0xE7, &byData);
-			if (byData == 0x14) {
+			bb_read_embedded(priv, 0xE7, &data);
+			if (data == 0x14) {
 				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
 				bb_write_embedded(priv, 0xE1, 0x57);
 			}
@@ -220,14 +220,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
 			priv->abyBBVGA[0] = 0x1C;
 			priv->abyBBVGA[2] = 0x00;
 			priv->abyBBVGA[3] = 0x00;
-			bb_read_embedded(priv, 0xE7, &byData);
-			if (byData == 0x20)
+			bb_read_embedded(priv, 0xE7, &data);
+			if (data == 0x20)
 				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
 
 		} else if (priv->byRFType == RF_UW2452) {
 			priv->abyBBVGA[0] = 0x14;
-			bb_read_embedded(priv, 0xE7, &byData);
-			if (byData == 0x18) {
+			bb_read_embedded(priv, 0xE7, &data);
+			if (data == 0x18) {
 				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
 				bb_write_embedded(priv, 0xE1, 0xD3);
 			}
@@ -243,14 +243,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
 			priv->abyBBVGA[0] = 0x1C;
 			priv->abyBBVGA[2] = 0x00;
 			priv->abyBBVGA[3] = 0x00;
-			bb_read_embedded(priv, 0xE7, &byData);
-			if (byData == 0x20)
+			bb_read_embedded(priv, 0xE7, &data);
+			if (data == 0x20)
 				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
 
 		} else if (priv->byRFType == RF_UW2452) {
 			priv->abyBBVGA[0] = 0x14;
-			bb_read_embedded(priv, 0xE7, &byData);
-			if (byData == 0x18) {
+			bb_read_embedded(priv, 0xE7, &data);
+			if (data == 0x18) {
 				bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
 				bb_write_embedded(priv, 0xE1, 0xD3);
 			}
@@ -798,12 +798,12 @@ bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF)
 {
 	void __iomem *iobase = priv->port_offset;
 	unsigned short ww;
-	unsigned char byData;
+	unsigned char data;
 
 	MACvRegBitsOn(iobase, MAC_REG_TFTCTL, TFTCTL_TSFCNTRRD);
 	for (ww = 0; ww < W_MAX_TIMEOUT; ww++) {
-		VNSvInPortB(iobase + MAC_REG_TFTCTL, &byData);
-		if (!(byData & TFTCTL_TSFCNTRRD))
+		VNSvInPortB(iobase + MAC_REG_TFTCTL, &data);
+		if (!(data & TFTCTL_TSFCNTRRD))
 			break;
 	}
 	if (ww == W_MAX_TIMEOUT)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] staging: vt6655: fix camelcase byData in card.c
  2021-10-18 19:21 [PATCH v2] staging: vt6655: fix camelcase byData in card.c Tommaso Merciai
@ 2021-10-19  5:49 ` Greg Kroah-Hartman
  2021-10-24 18:43   ` Tommaso Merciai
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2021-10-19  5:49 UTC (permalink / raw)
  To: Tommaso Merciai
  Cc: Forest Bond, Marcos Antonio de Jesus Filho, Dan Carpenter,
	Lucas Henneman, linux-staging, linux-kernel

On Mon, Oct 18, 2021 at 09:21:22PM +0200, Tommaso Merciai wrote:
> Replace camelcase variable "byData" into linux kernel coding style
> equivalent variable "data" in card.c.
> "by" prefix in hungarian notation stands for byte or unsigned char
> 
> References:
>  - https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm

Don't provide web links in a changelog text, they might not endure.

>  - https://www.kernel.org/doc/html/v4.10/process/coding-style.html

Why the old and obsolete 4.10 kernel document?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] staging: vt6655: fix camelcase byData in card.c
  2021-10-19  5:49 ` Greg Kroah-Hartman
@ 2021-10-24 18:43   ` Tommaso Merciai
  0 siblings, 0 replies; 3+ messages in thread
From: Tommaso Merciai @ 2021-10-24 18:43 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Forest Bond, Marcos Antonio de Jesus Filho, Dan Carpenter,
	Lucas Henneman, linux-staging, linux-kernel

On Tue, Oct 19, 2021 at 07:49:44AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 18, 2021 at 09:21:22PM +0200, Tommaso Merciai wrote:
> > Replace camelcase variable "byData" into linux kernel coding style
> > equivalent variable "data" in card.c.
> > "by" prefix in hungarian notation stands for byte or unsigned char
> > 
> > References:
> >  - https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
> 
> Don't provide web links in a changelog text, they might not endure.
> 
> >  - https://www.kernel.org/doc/html/v4.10/process/coding-style.html
> 
> Why the old and obsolete 4.10 kernel document?
> 
> thanks,
> 
> greg k-h

  Hi Greg,
  I'll update and resend.
  
  Thanks,
  Tommaso

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-24 18:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 19:21 [PATCH v2] staging: vt6655: fix camelcase byData in card.c Tommaso Merciai
2021-10-19  5:49 ` Greg Kroah-Hartman
2021-10-24 18:43   ` Tommaso Merciai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).