linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: iio: adc: ad7280a: fixed coding style
@ 2021-10-20  6:10 sesankm
  2021-10-20  6:33 ` Greg KH
  2021-10-20 20:31 ` Jonathan Cameron
  0 siblings, 2 replies; 3+ messages in thread
From: sesankm @ 2021-10-20  6:10 UTC (permalink / raw)
  To: lars
  Cc: Michael.Hennerich, jic23, gregkh, linux-iio, linux-staging,
	linux-kernel, sesankm

fixed issue with coding style

Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>
---
 drivers/staging/iio/adc/ad7280a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index fef0055b8990..473f95118214 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -829,14 +829,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
  * The function argument is stringified and doesn't need a fix
  */
 static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
-			     in_voltage-voltage_thresh_low_value,
+			     in_voltage - voltage_thresh_low_value,
 			     0644,
 			     ad7280_read_channel_config,
 			     ad7280_write_channel_config,
 			     AD7280A_CELL_UNDERVOLTAGE);
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
-			     in_voltage-voltage_thresh_high_value,
+			     in_voltage - voltage_thresh_high_value,
 			     0644,
 			     ad7280_read_channel_config,
 			     ad7280_write_channel_config,
-- 
2.33.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: iio: adc: ad7280a: fixed coding style
  2021-10-20  6:10 [PATCH] Staging: iio: adc: ad7280a: fixed coding style sesankm
@ 2021-10-20  6:33 ` Greg KH
  2021-10-20 20:31 ` Jonathan Cameron
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-10-20  6:33 UTC (permalink / raw)
  To: sesankm
  Cc: lars, Michael.Hennerich, jic23, linux-iio, linux-staging,
	linux-kernel, sesankm

On Wed, Oct 20, 2021 at 01:10:27AM -0500, sesankm wrote:
> fixed issue with coding style
> 
> Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>
> ---
>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index fef0055b8990..473f95118214 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -829,14 +829,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
>   * The function argument is stringified and doesn't need a fix
>   */
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> -			     in_voltage-voltage_thresh_low_value,
> +			     in_voltage - voltage_thresh_low_value,
>  			     0644,
>  			     ad7280_read_channel_config,
>  			     ad7280_write_channel_config,
>  			     AD7280A_CELL_UNDERVOLTAGE);
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> -			     in_voltage-voltage_thresh_high_value,
> +			     in_voltage - voltage_thresh_high_value,
>  			     0644,
>  			     ad7280_read_channel_config,
>  			     ad7280_write_channel_config,
> -- 
> 2.33.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch breaks the build.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: iio: adc: ad7280a: fixed coding style
  2021-10-20  6:10 [PATCH] Staging: iio: adc: ad7280a: fixed coding style sesankm
  2021-10-20  6:33 ` Greg KH
@ 2021-10-20 20:31 ` Jonathan Cameron
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2021-10-20 20:31 UTC (permalink / raw)
  To: sesankm
  Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-staging,
	linux-kernel, sesankm

On Wed, 20 Oct 2021 01:10:27 -0500
sesankm <sesank.mallikarjuna@gmail.com> wrote:

> fixed issue with coding style
> 
> Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>

Ah. Our 'favourite' false positive.  Take a look at what that macro
is doing..

There is a series waiting for review that removes this code anyway...
https://patchwork.kernel.org/project/linux-iio/list/?series=499867

> ---
>  drivers/staging/iio/adc/ad7280a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index fef0055b8990..473f95118214 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -829,14 +829,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
>   * The function argument is stringified and doesn't need a fix
>   */
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> -			     in_voltage-voltage_thresh_low_value,
> +			     in_voltage - voltage_thresh_low_value,
>  			     0644,
>  			     ad7280_read_channel_config,
>  			     ad7280_write_channel_config,
>  			     AD7280A_CELL_UNDERVOLTAGE);
>  
>  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> -			     in_voltage-voltage_thresh_high_value,
> +			     in_voltage - voltage_thresh_high_value,
>  			     0644,
>  			     ad7280_read_channel_config,
>  			     ad7280_write_channel_config,


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-20 20:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20  6:10 [PATCH] Staging: iio: adc: ad7280a: fixed coding style sesankm
2021-10-20  6:33 ` Greg KH
2021-10-20 20:31 ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).