linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mmc: winbond: don't build on M68K
@ 2021-10-17 17:59 Randy Dunlap
  2021-10-17 19:20 ` Arnd Bergmann
  2021-10-19 10:59 ` Ulf Hansson
  0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-10-17 17:59 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Pierre Ossman, Ulf Hansson, linux-mmc,
	Geert Uytterhoeven, linux-m68k, Arnd Bergmann

The Winbond MMC driver fails to build on ARCH=m68k so prevent
that build config. Silences these build errors:

../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
  212 |                 dmaflags = claim_dma_lock();
../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
  215 |                 release_dma_lock(dmaflags);

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Pierre Ossman <pierre@ossman.eu>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20211015.orig/drivers/mmc/host/Kconfig
+++ linux-next-20211015/drivers/mmc/host/Kconfig
@@ -508,7 +508,7 @@ config MMC_OMAP_HS
 
 config MMC_WBSD
 	tristate "Winbond W83L51xD SD/MMC Card Interface support"
-	depends on ISA_DMA_API
+	depends on ISA_DMA_API && !M68K
 	help
 	  This selects the Winbond(R) W83L51xD Secure digital and
 	  Multimedia card Interface.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mmc: winbond: don't build on M68K
  2021-10-17 17:59 [PATCH] mmc: winbond: don't build on M68K Randy Dunlap
@ 2021-10-17 19:20 ` Arnd Bergmann
  2021-10-17 19:31   ` Randy Dunlap
  2021-10-19 10:59 ` Ulf Hansson
  1 sibling, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2021-10-17 19:20 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, Pierre Ossman, Ulf Hansson, linux-mmc,
	Geert Uytterhoeven, linux-m68k, Arnd Bergmann

On Sun, Oct 17, 2021 at 7:59 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> The Winbond MMC driver fails to build on ARCH=m68k so prevent
> that build config. Silences these build errors:
>
> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>   212 |                 dmaflags = claim_dma_lock();
> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
>   215 |                 release_dma_lock(dmaflags);
>

It looks like m68k and sparc declare this function in asm/floppy.h,
while everyone
else has it in asm/dma.h.

Not sure if it's worth fixing in a better way, but I suspect sparc
would have the
same issue here.

      Arnd

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mmc: winbond: don't build on M68K
  2021-10-17 19:20 ` Arnd Bergmann
@ 2021-10-17 19:31   ` Randy Dunlap
  2021-10-18  4:18     ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2021-10-17 19:31 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Linux Kernel Mailing List, Pierre Ossman, Ulf Hansson, linux-mmc,
	Geert Uytterhoeven, linux-m68k

On 10/17/21 12:20 PM, Arnd Bergmann wrote:
> On Sun, Oct 17, 2021 at 7:59 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> The Winbond MMC driver fails to build on ARCH=m68k so prevent
>> that build config. Silences these build errors:
>>
>> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
>> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>>    212 |                 dmaflags = claim_dma_lock();
>> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
>>    215 |                 release_dma_lock(dmaflags);
>>
> 
> It looks like m68k and sparc declare this function in asm/floppy.h,
> while everyone
> else has it in asm/dma.h.
> 
> Not sure if it's worth fixing in a better way, but I suspect sparc
> would have the
> same issue here.

Ah, I should have seen that.
I'll look into a different patch.

thanks.
-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mmc: winbond: don't build on M68K
  2021-10-17 19:31   ` Randy Dunlap
@ 2021-10-18  4:18     ` Randy Dunlap
  0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2021-10-18  4:18 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Linux Kernel Mailing List, Pierre Ossman, Ulf Hansson, linux-mmc,
	Geert Uytterhoeven, linux-m68k

On 10/17/21 12:31 PM, Randy Dunlap wrote:
> On 10/17/21 12:20 PM, Arnd Bergmann wrote:
>> On Sun, Oct 17, 2021 at 7:59 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> The Winbond MMC driver fails to build on ARCH=m68k so prevent
>>> that build config. Silences these build errors:
>>>
>>> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
>>> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>>>    212 |                 dmaflags = claim_dma_lock();
>>> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
>>>    215 |                 release_dma_lock(dmaflags);
>>>
>>
>> It looks like m68k and sparc declare this function in asm/floppy.h,
>> while everyone
>> else has it in asm/dma.h.
>>
>> Not sure if it's worth fixing in a better way, but I suspect sparc
>> would have the
>> same issue here.
> 
> Ah, I should have seen that.
> I'll look into a different patch.
> 
> thanks.


OK, I have spent several hours on moving dma functions from floppy.h
to dma.h (for m68k), and it fixes a few things, but there are still
quite a few problems, and I don't see any end in sight (it's either
a maze of twisty tunnels or a twisty maze of tunnels), and it's just
not worth spending more time on it IMO.

-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mmc: winbond: don't build on M68K
  2021-10-17 17:59 [PATCH] mmc: winbond: don't build on M68K Randy Dunlap
  2021-10-17 19:20 ` Arnd Bergmann
@ 2021-10-19 10:59 ` Ulf Hansson
  1 sibling, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2021-10-19 10:59 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux Kernel Mailing List, Pierre Ossman, linux-mmc,
	Geert Uytterhoeven, linux-m68k, Arnd Bergmann

On Sun, 17 Oct 2021 at 19:59, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> The Winbond MMC driver fails to build on ARCH=m68k so prevent
> that build config. Silences these build errors:
>
> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>   212 |                 dmaflags = claim_dma_lock();
> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
>   215 |                 release_dma_lock(dmaflags);
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Pierre Ossman <pierre@ossman.eu>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mmc@vger.kernel.org
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: Arnd Bergmann <arnd@arndb.de>

Applied for fixes, thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20211015.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20211015/drivers/mmc/host/Kconfig
> @@ -508,7 +508,7 @@ config MMC_OMAP_HS
>
>  config MMC_WBSD
>         tristate "Winbond W83L51xD SD/MMC Card Interface support"
> -       depends on ISA_DMA_API
> +       depends on ISA_DMA_API && !M68K
>         help
>           This selects the Winbond(R) W83L51xD Secure digital and
>           Multimedia card Interface.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-19 11:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-17 17:59 [PATCH] mmc: winbond: don't build on M68K Randy Dunlap
2021-10-17 19:20 ` Arnd Bergmann
2021-10-17 19:31   ` Randy Dunlap
2021-10-18  4:18     ` Randy Dunlap
2021-10-19 10:59 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).