linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] mmc: sdhci-omap: Remove forward declaration of sdhci_omap_context_save()
@ 2021-10-20  8:39 Geert Uytterhoeven
  2021-10-21 19:48 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-10-20  8:39 UTC (permalink / raw)
  To: Tony Lindgren, Kishon Vijay Abraham I, Adrian Hunter, Ulf Hansson
  Cc: linux-mmc, linux-kernel

If CONFIG_PM_SLEEP=n:

    drivers/mmc/host/sdhci-omap.c:1213:13: error: ‘sdhci_omap_context_save’ declared ‘static’ but never defined [-Werror=unused-function]
     1213 | static void sdhci_omap_context_save(struct sdhci_omap_host *omap_host);
	  |             ^~~~~~~~~~~~~~~~~~~~~~~

The referenced commit added an unrelated forward declaration of
sdhci_omap_context_save(), which is unneeded in general, and unused when
CONFIG_PM_SLEEP=n.

Fixes: f433e8aac6b94218 ("mmc: sdhci-omap: Implement PM runtime functions")
Reported-by: noreply@ellerman.id.au
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mmc/host/sdhci-omap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 0dec2f849b81e242..a4a1734dcb84e9cf 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -1210,8 +1210,6 @@ static const struct soc_device_attribute sdhci_omap_soc_devices[] = {
 	}
 };
 
-static void sdhci_omap_context_save(struct sdhci_omap_host *omap_host);
-
 static int sdhci_omap_probe(struct platform_device *pdev)
 {
 	int ret;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] mmc: sdhci-omap: Remove forward declaration of sdhci_omap_context_save()
  2021-10-20  8:39 [PATCH -next] mmc: sdhci-omap: Remove forward declaration of sdhci_omap_context_save() Geert Uytterhoeven
@ 2021-10-21 19:48 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-10-21 19:48 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Tony Lindgren, Kishon Vijay Abraham I, Adrian Hunter, linux-mmc,
	Linux Kernel Mailing List

On Wed, 20 Oct 2021 at 11:05, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> If CONFIG_PM_SLEEP=n:
>
>     drivers/mmc/host/sdhci-omap.c:1213:13: error: ‘sdhci_omap_context_save’ declared ‘static’ but never defined [-Werror=unused-function]
>      1213 | static void sdhci_omap_context_save(struct sdhci_omap_host *omap_host);
>           |             ^~~~~~~~~~~~~~~~~~~~~~~
>
> The referenced commit added an unrelated forward declaration of
> sdhci_omap_context_save(), which is unneeded in general, and unused when
> CONFIG_PM_SLEEP=n.
>
> Fixes: f433e8aac6b94218 ("mmc: sdhci-omap: Implement PM runtime functions")
> Reported-by: noreply@ellerman.id.au
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-omap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 0dec2f849b81e242..a4a1734dcb84e9cf 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -1210,8 +1210,6 @@ static const struct soc_device_attribute sdhci_omap_soc_devices[] = {
>         }
>  };
>
> -static void sdhci_omap_context_save(struct sdhci_omap_host *omap_host);
> -
>  static int sdhci_omap_probe(struct platform_device *pdev)
>  {
>         int ret;
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-21 19:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20  8:39 [PATCH -next] mmc: sdhci-omap: Remove forward declaration of sdhci_omap_context_save() Geert Uytterhoeven
2021-10-21 19:48 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).