linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Fix debugfs entry leak in hci_register_dev()
@ 2021-10-13  8:55 Wei Yongjun
  2021-10-13  9:10 ` bluez.test.bot
  2021-10-13 12:29 ` [PATCH] " Marcel Holtmann
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2021-10-13  8:55 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: Wei Yongjun, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz

Fault injection test report debugfs entry leak as follows:

debugfs: Directory 'hci0' with parent 'bluetooth' already present!

When register_pm_notifier() failed in hci_register_dev(), the debugfs
create by debugfs_create_dir() do not removed in the error handing path.

Add the remove debugfs code to fix it.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 8a47a3017d61..cc48a8a9901c 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3998,6 +3998,7 @@ int hci_register_dev(struct hci_dev *hdev)
 	return id;
 
 err_wqueue:
+	debugfs_remove_recursive(hdev->debugfs);
 	destroy_workqueue(hdev->workqueue);
 	destroy_workqueue(hdev->req_workqueue);
 err:
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: Bluetooth: Fix debugfs entry leak in hci_register_dev()
  2021-10-13  8:55 [PATCH] Bluetooth: Fix debugfs entry leak in hci_register_dev() Wei Yongjun
@ 2021-10-13  9:10 ` bluez.test.bot
  2021-10-13 12:29 ` [PATCH] " Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-10-13  9:10 UTC (permalink / raw)
  To: linux-bluetooth, weiyongjun1

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=562483

---Test result---

Test Summary:
CheckPatch                    PASS      1.89 seconds
GitLint                       PASS      0.96 seconds
BuildKernel                   PASS      528.68 seconds
TestRunner: Setup             PASS      412.56 seconds
TestRunner: l2cap-tester      PASS      9.14 seconds
TestRunner: bnep-tester       PASS      4.59 seconds
TestRunner: mgmt-tester       PASS      84.08 seconds
TestRunner: rfcomm-tester     PASS      5.58 seconds
TestRunner: sco-tester        PASS      6.17 seconds
TestRunner: smp-tester        PASS      5.86 seconds
TestRunner: userchan-tester   PASS      4.89 seconds



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44357 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3564 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 646011 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11684 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13924 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11830 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 6371 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: Fix debugfs entry leak in hci_register_dev()
  2021-10-13  8:55 [PATCH] Bluetooth: Fix debugfs entry leak in hci_register_dev() Wei Yongjun
  2021-10-13  9:10 ` bluez.test.bot
@ 2021-10-13 12:29 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2021-10-13 12:29 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: linux-bluetooth, Johan Hedberg, Luiz Augusto von Dentz

Hi Wei,

> Fault injection test report debugfs entry leak as follows:
> 
> debugfs: Directory 'hci0' with parent 'bluetooth' already present!
> 
> When register_pm_notifier() failed in hci_register_dev(), the debugfs
> create by debugfs_create_dir() do not removed in the error handing path.
> 
> Add the remove debugfs code to fix it.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-13 12:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-13  8:55 [PATCH] Bluetooth: Fix debugfs entry leak in hci_register_dev() Wei Yongjun
2021-10-13  9:10 ` bluez.test.bot
2021-10-13 12:29 ` [PATCH] " Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).