linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btsdio: Do not bind to non-removable BCM4345 and BCM43455
@ 2021-10-20 13:00 Kyle Copperfield
  2021-10-20 13:05 ` Marcel Holtmann
  2021-10-20 14:12 ` bluez.test.bot
  0 siblings, 2 replies; 3+ messages in thread
From: Kyle Copperfield @ 2021-10-20 13:00 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz
  Cc: Kyle Copperfield, Dragan Simic, linux-bluetooth, linux-kernel

BCM4345 and BCM43455 devices soldered onto the PCB (non-removable),
use an UART connection for Bluetooth, such as in the Pinebook Pro,
and the advertised btsdio support as an SDIO function is ignored.

Reviewed-by: Dragan Simic <dragan.simic@gmail.com>
Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
---
 drivers/bluetooth/btsdio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
index 199e8f7d426d..795be33f2892 100644
--- a/drivers/bluetooth/btsdio.c
+++ b/drivers/bluetooth/btsdio.c
@@ -295,6 +295,8 @@ static int btsdio_probe(struct sdio_func *func,
 		switch (func->device) {
 		case SDIO_DEVICE_ID_BROADCOM_43341:
 		case SDIO_DEVICE_ID_BROADCOM_43430:
+		case SDIO_DEVICE_ID_BROADCOM_4345:
+		case SDIO_DEVICE_ID_BROADCOM_43455:
 		case SDIO_DEVICE_ID_BROADCOM_4356:
 			return -ENODEV;
 		}
-- 
2.33.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: btsdio: Do not bind to non-removable BCM4345 and BCM43455
  2021-10-20 13:00 [PATCH] Bluetooth: btsdio: Do not bind to non-removable BCM4345 and BCM43455 Kyle Copperfield
@ 2021-10-20 13:05 ` Marcel Holtmann
  2021-10-20 14:12 ` bluez.test.bot
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2021-10-20 13:05 UTC (permalink / raw)
  To: Kyle Copperfield
  Cc: Johan Hedberg, Luiz Augusto von Dentz, Dragan Simic,
	linux-bluetooth, linux-kernel

Hi Kyle,

> BCM4345 and BCM43455 devices soldered onto the PCB (non-removable),
> use an UART connection for Bluetooth, such as in the Pinebook Pro,
> and the advertised btsdio support as an SDIO function is ignored.
> 
> Reviewed-by: Dragan Simic <dragan.simic@gmail.com>
> Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me>
> ---
> drivers/bluetooth/btsdio.c | 2 ++
> 1 file changed, 2 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: Bluetooth: btsdio: Do not bind to non-removable BCM4345 and BCM43455
  2021-10-20 13:00 [PATCH] Bluetooth: btsdio: Do not bind to non-removable BCM4345 and BCM43455 Kyle Copperfield
  2021-10-20 13:05 ` Marcel Holtmann
@ 2021-10-20 14:12 ` bluez.test.bot
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-10-20 14:12 UTC (permalink / raw)
  To: linux-bluetooth, kmcopper

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=567031

---Test result---

Test Summary:
CheckPatch                    PASS      0.75 seconds
GitLint                       PASS      0.31 seconds
BuildKernel                   PASS      660.93 seconds
TestRunner: Setup             PASS      491.78 seconds
TestRunner: l2cap-tester      PASS      10.53 seconds
TestRunner: bnep-tester       PASS      5.47 seconds
TestRunner: mgmt-tester       PASS      99.63 seconds
TestRunner: rfcomm-tester     PASS      6.80 seconds
TestRunner: sco-tester        PASS      7.18 seconds
TestRunner: smp-tester        PASS      6.79 seconds
TestRunner: userchan-tester   PASS      5.65 seconds



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44357 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3562 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 646011 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11684 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13924 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11830 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 6372 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-20 14:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 13:00 [PATCH] Bluetooth: btsdio: Do not bind to non-removable BCM4345 and BCM43455 Kyle Copperfield
2021-10-20 13:05 ` Marcel Holtmann
2021-10-20 14:12 ` bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).